Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drain entire render queue in a single microtask #1135

Merged
merged 5 commits into from Aug 17, 2018
Merged

Drain entire render queue in a single microtask #1135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
70c657a
Drain entire render queue in a single microtask, even as new items ar…
rpetrich Jun 5, 2018
ce7370b
Merge branch 'master' into drain-in-single-microtask
developit Jun 9, 2018
4ebb16d
Merge branch 'master' into drain-in-single-microtask
developit Jul 4, 2018
9806045
Merge branch 'master' into drain-in-single-microtask
rpetrich Aug 5, 2018
3c17e3e
Merge branch 'master' into drain-in-single-microtask
developit Aug 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/render-queue.js
View file
Open in desktop
Expand Up @@ -20,9 +20,8 @@ export function enqueueRender(component) {

/** Rerender all enqueued dirty components */
export function rerender() {
let p, list = items;
items = [];
while ( (p = list.pop()) ) {
let p;
while ( (p = items.pop()) ) {
if (p._dirty) renderComponent(p);
}
}
19 changes: 19 additions & 0 deletions test/browser/lifecycle.js
View file
Open in desktop
Expand Up @@ -1440,6 +1440,25 @@ describe('Lifecycle methods', () => {


describe('Lifecycle DOM Timing', () => {
it('should render in a single microtask', () => {
class Counter extends Component {
constructor() {
super();
this.state = { count: 0 };
}
render(props, { count }) {
if (count < 2) {
this.setState({ count: count + 1 });
}
return count;
}
}
render(<Counter />, scratch);
rerender();
expect(scratch.textContent).to.equal("2");
rerender();
});

it('should be invoked when dom does (DidMount, WillUnmount) or does not (WillMount, DidUnmount) exist', () => {
let setState;
class Outer extends Component {
Expand Down