Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline setProperty function #1122

Merged
merged 2 commits into from May 27, 2018
Merged

Inline setProperty function #1122

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ae6f88
Inline setProperty
andrewiggins May 26, 2018
6887680
Merge branch 'master' into inline-set-property
andrewiggins May 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 5 additions & 12 deletions src/dom/index.js
View file
Open in desktop
Expand Up @@ -80,7 +80,11 @@ export function setAccessor(node, name, old, value, isSvg) {
(node._listeners || (node._listeners = {}))[name] = value;
}
else if (name!=='list' && name!=='type' && !isSvg && name in node) {
setProperty(node, name, value==null ? '' : value);
// Attempt to set a DOM property to the given value.
// IE & FF throw for certain property-value combinations.
try {
node[name] = value==null ? '' : value;
} catch (e) { }
if ((value==null || value===false) && name!='spellcheck') node.removeAttribute(name);
}
else {
Expand All @@ -100,17 +104,6 @@ export function setAccessor(node, name, old, value, isSvg) {
}


/**
* Attempt to set a DOM property to the given value.
* IE & FF throw for certain property-value combinations.
*/
function setProperty(node, name, value) {
try {
node[name] = value;
} catch (e) { }
}


/**
* Proxy an event to hooked event handlers
* @private
Expand Down