Merge pull request #1211 from lowaa/remove-mounts-unshift

Chrome poor performance when calling array.unshift on a large array.
preactjs · Sep 24, 2018 · 1369ab3 · 1369ab3
2 parents b5c4a36 + 9b81167
commit 1369ab3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/vdom/component.js b/src/vdom/component.js
@@ -189,7 +189,7 @@ export function renderComponent(component, renderMode, mountAll, isChild) {
 	}
 
 	if (!isUpdate || mountAll) {
-		mounts.unshift(component);
+		mounts.push(component);
 	}
 	else if (!skip) {
 		// Ensure that pending componentDidMount() hooks of child components

diff --git a/src/vdom/diff.js b/src/vdom/diff.js
@@ -24,11 +24,13 @@ let hydrating = false;
 
 /** Invoke queued componentDidMount lifecycle methods */
 export function flushMounts() {
-	let c;
-	while ((c=mounts.pop())) {
+	let c, i;
+	for (i=0; i<mounts.length; ++i) {
+		c = mounts[i];
 		if (options.afterMount) options.afterMount(c);
 		if (c.componentDidMount) c.componentDidMount();
 	}
+	mounts.length = 0;
 }