Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Use React.StrictMode #55

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[WIP] Use React.StrictMode #55

wants to merge 2 commits into from

Conversation

wilzbach
Copy link
Contributor

@wilzbach wilzbach commented Oct 27, 2018

StrictMode is a tool for highlighting potential problems in an application. Like Fragment, StrictMode does not render any visible UI. It activates additional checks and warnings for its descendants.

See also: https://reactjs.org/docs/strict-mode.html

Still requires some work:

  • componentWillMount: Please update the following components to use componentDidMount instead: FakeScroll, HTMLLabelsComponent, HTMLOverviewBarComponent, HTMLPositionBarComponent, ListComponent, MSAViewerComponent, SequenceViewerComponent, XBarComponent, YBarComponent

  • componentWillReceiveProps: Please update the following components to use static getDerivedStateFromProps instead: Connect(HTMLLabelsComponent), Connect(HTMLOverviewBarComponent), Connect(HTMLPositionBarComponent), Connect(SequenceViewerComponent), Provider

  • componentWillUpdate: Please update the following components to use componentDidUpdate instead: Connect(HTMLLabelsComponent), Connect(HTMLOverviewBarComponent), Connect(HTMLPositionBarComponent), Connect(SequenceViewerComponent), HTMLPositionBarComponent

@wilzbach wilzbach added this to In progess in Sprint 1 Oct 28, 2018
@wilzbach wilzbach moved this from In progess to To Do in Sprint 1 Oct 28, 2018
@wilzbach
Copy link
Contributor Author

wilzbach commented Oct 29, 2018

Blocked by #58

StrictMode is a tool for highlighting potential problems in an application. Like Fragment, StrictMode does not render any visible UI. It activates additional checks and warnings for its descendants.

See also: https://reactjs.org/docs/strict-mode.html
@wilzbach
Copy link
Contributor Author

React-redux isn't compatible with React.StrictMode yet.
See e.g reduxjs/react-redux#897

Though reduxjs/react-redux#1000 looks like this could change soon (:

@wilzbach wilzbach moved this from To Do to Backlog in Sprint 1 Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Sprint 1
  
Backlog
Development

Successfully merging this pull request may close these issues.

None yet

1 participant