Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wildcard redacting with a custom censor function #617

Merged
merged 1 commit into from Mar 27, 2019
Merged

Fix wildcard redacting with a custom censor function #617

merged 1 commit into from Mar 27, 2019

Conversation

runk
Copy link
Contributor

@runk runk commented Mar 24, 2019

Fixes #613

mcollina
mcollina approved these changes Mar 24, 2019
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@runk
Copy link
Contributor Author

runk commented Mar 26, 2019

@mcollina what's the process of getting this pr into master?

@mcollina mcollina merged commit 8551286 into pinojs:master Mar 27, 2019
@mcollina
Copy link
Member

I was just waiting others to review, but I think we can release this now.

@runk runk deleted the fix-top-level-censor-fn branch March 28, 2019 02:19
@github-actions
Copy link

github-actions bot commented Feb 5, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Top level redacting with censor function
2 participants
@runk @mcollina