Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docs about the new censor function. #553

Merged
merged 3 commits into from Nov 22, 2018
Merged

Added docs about the new censor function. #553

merged 3 commits into from Nov 22, 2018

Conversation

mcollina
Copy link
Member

We missed to update the docs.

Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit. Might also want to mention that the function must be synchronous.

docs/api.md Outdated
@@ -105,7 +105,9 @@ Each path must be a string using a syntax which corresponds to JavaScript dot an

If an object is supplied, three options can be specified:
* `paths` (array): Required. An array of paths. See [redaction - Path Syntax ⇗](/docs/redaction.md#paths) for specifics.
* `censor` (String): Optional. A value to overwrite key which are to be redacted. Default: `'[Redacted]'`
* `censor` (String|Function): Optional. A value to overwrite key which are to be redacted.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“key” => “keys”

@mcollina
Copy link
Member Author

PTAL

docs/api.md Outdated Show resolved Hide resolved
docs/api.md Outdated Show resolved Hide resolved
David Mark Clements and others added 2 commits November 22, 2018 18:58
Co-Authored-By: mcollina <matteo.collina@gmail.com>
Co-Authored-By: mcollina <matteo.collina@gmail.com>
@mcollina mcollina merged commit c2173f8 into master Nov 22, 2018
@mcollina mcollina deleted the censor-doc branch November 22, 2018 17:58
@github-actions
Copy link

github-actions bot commented Feb 6, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants