Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added note in the docs about Windows terminal and unicode #552

Merged
merged 1 commit into from Nov 22, 2018
Merged

Added note in the docs about Windows terminal and unicode #552

merged 1 commit into from Nov 22, 2018
+14 −0

Conversation

mcollina
Copy link
Member

Fixes #548.

jsumners
jsumners approved these changes Nov 22, 2018
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit 3b7019e into master Nov 22, 2018
@mcollina mcollina deleted the windows-terminal-docs-unicode branch November 22, 2018 17:14
@github-actions
Copy link

github-actions bot commented Feb 6, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jsumners jsumners jsumners approved these changes

@davidmarkclements davidmarkclements Awaiting requested review from davidmarkclements

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows: incorrect encoding on Unicode output
2 participants
@mcollina @jsumners