Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #4235. #4240

Closed
wants to merge 1 commit into from
Closed

Fix for issue #4235. #4240

wants to merge 1 commit into from

Conversation

AndrewDRX
Copy link

This PR:

  • Fixes a bug

Description:
Fix for issue #4235 . The issue occurs due to the use of a NaN result produced from a zero denominator equation.

@photonstorm
Copy link
Collaborator

Thanks for your PR. While it fixes the problem, it feels like the wrong place to do it, as it's going to do this check every frame, for every tween, which doesn't seem worth it for something that can be caught and handled before the tween even starts playing (zero durations).

I think we ought to trap this in the Tween.play method.

@photonstorm
Copy link
Collaborator

Thanks for the PR but I've resolved this issue via capping the duration during the init of the Tween.

@photonstorm photonstorm closed this Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants