This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
prefer-conditional-expression: avoid error on nested if statement #3528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[bugfix] `prefer-conditional-expression`: don't repeat error on nested if statements Fixes: #3350
ajafff
commented
Nov 29, 2017
| if (length === 1) { | ||
| x = "bar"; | ||
| } else { | ||
| if (length === 2) { |
There was a problem hiding this comment.
The error used to be reported on this line. I fixed that while I was already touching the code.
adidahiya
approved these changes
Nov 29, 2017
HyphnKnight
pushed a commit
to HyphnKnight/tslint
that referenced
this pull request
Apr 9, 2018
…lantir#3528) [bugfix] `prefer-conditional-expression`: don't repeat error on nested if statements Fixes: palantir#3350
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
[bugfix]
prefer-conditional-expression: don't repeat error on nested if statementsFixes: #3350
Is there anything you'd like reviewers to focus on?
To fix the above issue, only the change under the
// Be careful not to fail again for the "else if"comment is necessary.While adding tests, I noticed that
check-else-ifadded the error on the innerifwhen nesting with blocks. I fixed that along the way which leads to a bigger refactor.CHANGELOG.md entry: