This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Updated version of commander.js package #3510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your interest in palantir/tslint, @timocov! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
ajafff
approved these changes
Nov 23, 2017
|
How about bumping the minimum dep to 2.12.1 instead? tj/commander.js@a7124fc |
timocov
changed the title
|
@adidahiya sure. I have updated pr. |
ajafff
approved these changes
Nov 28, 2017
ajafff
reviewed
Nov 28, 2017
package.json
Outdated
| @@ -56,7 +56,7 @@ | |||
| "devDependencies": { | |||
| "@types/babel-code-frame": "^6.20.0", | |||
| "@types/chai": "^3.5.0", | |||
| "@types/commander": "^2.9.0", | |||
| "@types/commander": "^2.11.0", | |||
There was a problem hiding this comment.
Do we even need this now that the package contains declaration files?
There was a problem hiding this comment.
Removed @types package
adidahiya
approved these changes
Nov 28, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Changelog
[bugfix] Update commander.js dependency to prevent users from transitively installing a buggy 2.12.0 release