This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Update to typescript@2.6 #3320
Merged
Update to typescript@2.6 #3320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajafff
commented
Oct 14, 2017
package.json
Outdated
| @@ -76,7 +76,7 @@ | |||
| "ts-node": "^3.3.0", | |||
| "tslint": "^5.7.0", | |||
| "tslint-test-config-non-relative": "file:test/external/tslint-test-config-non-relative", | |||
| "typescript": "~2.5.1" | |||
| "typescript": "^2.6.0-dev.20171014" | |||
There was a problem hiding this comment.
This is not ready to be merged. We need to wait for the next official typescript release.
2.6.0-rc cannot be used because microsoft/TypeScript#19164 breaks the formatter tests
4 tasks
4 tasks
|
Still in-progress? Or are we good with the latest nightly? |
|
Code-wise I don't expect any changes. I'd like to wait for the stable release though. I expect it to be released this week. |
|
@adidahiya now that ts 2.6.1 is out, this PR should be good to go |
adidahiya
approved these changes
Oct 31, 2017
HyphnKnight
pushed a commit
to HyphnKnight/tslint
that referenced
this pull request
Apr 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
Update to ts@2.6.0
Remove type assertions. Fixes #3161
Enable
--strictFunctionTypescompiler option[bugfix]
--projectexcludes all files of exteral dependenciesFixes: #2827
Is there anything you'd like reviewers to focus on?
CHANGELOG.md entry: