This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
[no-unnecessary-type-assertion]: adds an option to ignore whitelisted type assertions. #3257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your interest in palantir/tslint, @bowenni! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
ajafff
reviewed
Sep 28, 2017
| @@ -61,7 +67,10 @@ class Walker extends Lint.AbstractWalker<void> { | |||
| } | |||
|
|
|||
| private verifyCast(node: ts.TypeAssertion | ts.NonNullExpression | ts.AsExpression) { | |||
| const castType = this.checker.getTypeAtLocation(node); | |||
| if (isAsExpression(node) && this.options.ruleArguments.indexOf(node.type.getText()) !== -1) { | |||
There was a problem hiding this comment.
Use isAssertionExpression to also handle <T>foo
ajafff
reviewed
Sep 28, 2017
| @@ -61,6 +67,9 @@ class Walker extends Lint.AbstractWalker<void> { | |||
| } | |||
|
|
|||
| private verifyCast(node: ts.TypeAssertion | ts.NonNullExpression | ts.AsExpression) { | |||
| if (isAssertionExpression(node) && this.options.ruleArguments.indexOf(node.type.getText()) !== -1) { | |||
There was a problem hiding this comment.
please pass the sourceFile as parameter to .getText() to avoid unnecessary lookup of the SourceFile
ajafff
reviewed
Sep 29, 2017
| @@ -36,13 +42,13 @@ export class Rule extends Lint.Rules.TypedRule { | |||
| public static FAILURE_STRING = "This assertion is unnecessary since it does not change the type of the expression."; | |||
|
|
|||
| public applyWithProgram(sourceFile: ts.SourceFile, program: ts.Program): Lint.RuleFailure[] { | |||
| return this.applyWithWalker(new Walker(sourceFile, this.ruleName, program.getTypeChecker())); | |||
| return this.applyWithWalker(new Walker(sourceFile, this.ruleName, this.getOptions(), program.getTypeChecker())); | |||
There was a problem hiding this comment.
you can use this.ruleArguments instead of this.getOptions()
you just need to change the type argument from Lint.IOptions to string[]
ajafff
approved these changes
Sep 29, 2017
whitelisted type assertions.
|
Thanks @bowenni |
HyphnKnight
pushed a commit
to HyphnKnight/tslint
that referenced
this pull request
Apr 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
In Google we use type aliases for the
anytype to remind the developers that the type is loose and they need to fix it. This option allows "no-unnecessary-type-assertion" to ignore those explicitly added assertions.Is there anything you'd like reviewers to focus on?
CHANGELOG.md entry: