Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

New rule no-return-await #3233

Merged
merged 5 commits into from Oct 20, 2017
Merged

New rule no-return-await #3233

merged 5 commits into from Oct 20, 2017

Conversation

ajafff
Copy link
Contributor

@ajafff ajafff commented Sep 17, 2017

PR checklist

  • Addresses an existing issue: #0000
  • New feature, bugfix, or enhancement
    • Includes tests
  • Documentation update

Overview of change:

Is there anything you'd like reviewers to focus on?

CHANGELOG.md entry:

[new-rule] no-return-await

@adidahiya adidahiya self-assigned this Oct 19, 2017
@adidahiya adidahiya merged commit 37ab258 into palantir:master Oct 20, 2017
@develar
Copy link

develar commented Oct 23, 2017

👎 to include this rule by default to latest. I don't want to spend hours to debug why my try-catch doesn't work some time later (or another colleague in my team). Just because I forgot to insert missed await. i.e. when you modify your code and this return statement will be not latest in the function body.

@ajafff ajafff deleted the no-return-await branch October 23, 2017 17:26
@adidahiya
Copy link
Contributor

Just because I forgot to insert missed await

@develar that sounds like the job of another lint rule -- check out no-floating-promises

HyphnKnight pushed a commit to HyphnKnight/tslint that referenced this pull request Apr 9, 2018
[new-rule] `no-return-await`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants