Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

restrict-plus-operands: Minor error message change. #3220

Merged
merged 1 commit into from Sep 13, 2017

Conversation

bowenni
Copy link
Contributor

@bowenni bowenni commented Sep 13, 2017

PR checklist

  • Addresses an existing issue: #0000
  • New feature, bugfix, or enhancement
    • Includes tests
  • Documentation update

Overview of change:

Suggest template literals when an operand is a string.
Most violations in Google code base is "string + number". Users might do .toString() to pass this check if they didn't know about template literals.

Is there anything you'd like reviewers to focus on?

CHANGELOG.md entry:

[enhancement] restrict-plus-operands: More specific error message when arguments include strings

@palantirtech
Copy link
Member

Thanks for your interest in palantir/tslint, @bowenni! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@bowenni
Copy link
Contributor Author

bowenni commented Sep 13, 2017

I am covered by the Google corporate CLA.

@adidahiya adidahiya merged commit cd355e6 into palantir:master Sep 13, 2017
HyphnKnight pushed a commit to HyphnKnight/tslint that referenced this pull request Apr 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants