Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

chore: switch from colors.js to chalk #3171

Merged
merged 2 commits into from Sep 26, 2017
Merged

Conversation

zetorama
Copy link
Contributor

PR checklist

  • Addresses an existing issue: #0000
  • New feature, bugfix, or enhancement
    • Includes tests
  • Documentation update

Overview of change:

This PR makes a switch from colors.js dependency to a similar, but modern library chalk. The motivation is to be able to force output coloring when running tslint as a forked process. Such migration allows to just add the environment variable FORCE_COLOR=1.

See also #3144, as it explains why I came to such changes. Both libraries have similar API, so most diff was automated by typescript's refactor ability.

Is there anything you'd like reviewers to focus on?

Note, there is WIP on bundling typescript definitions within chalk. For now, It seems enough to use current version of @types/chalk.

Also, there is still a colors.js mention in yarn.lock. Obviously, It should be gone away when you update tslint version in devDeps.

CHANGELOG.md entry:

chore: switch from colors.js to chalk

@palantirtech
Copy link
Member

Thanks for your interest in palantir/tslint, @zetorama! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@adidahiya
Copy link
Contributor

@zetorama let me know if you have any issues signing the CLA?

@zetorama
Copy link
Contributor Author

zetorama commented Sep 4, 2017

Sorry for a long delay.

@adidahiya , I've got "I don't have any problems with it" from my employer. But I have a different kind of question — how can I change my name on the document? (As I use a pseudonym here, on github.)

Thanks.

@ajafff ajafff merged commit 02dd308 into palantir:master Sep 26, 2017
HyphnKnight pushed a commit to HyphnKnight/tslint that referenced this pull request Apr 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants