This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
applyWithFunction: allow passing TypeChecker or Program directly #3140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change we no longer need a closure to pass the TypeChecker of Program to the walkFn. [api] `applyWithFunction` allows additional parameter that is passed through to `walkFn`
adidahiya
approved these changes
Aug 18, 2017
HyphnKnight
pushed a commit
to HyphnKnight/tslint
that referenced
this pull request
Apr 9, 2018
…antir#3140) With this change we no longer need a closure to pass the TypeChecker of Program to the walkFn. [api] `applyWithFunction` allows additional parameter that is passed through to `walkFn`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
With this change we no longer need a closure to pass the
TypeCheckerorProgramto thewalkFn.Is there anything you'd like reviewers to focus on?
CHANGELOG.md entry:
[api]
AbstractRule#applyWithFunctionallows additional parameter that is passed through towalkFn