This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Update ordered-imports rule: add default grouping #3138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adidahiya @ajafff what's the status on this? |
ajafff
approved these changes
Sep 8, 2017
| @@ -372,6 +498,11 @@ function removeQuotes(value: string): string { | |||
| return value; | |||
| } | |||
|
|
|||
| function getSortedImportDeclarationsAsText(importDeclarations: ImportDeclaration[]): string { | |||
| const sortedDeclarations = sortByKey(importDeclarations.slice(), (x) => x.sourcePath); | |||
There was a problem hiding this comment.
No need to pass a slice. The function creates a new array anyway
adidahiya
approved these changes
Sep 8, 2017
|
Love it, thanks. |
HyphnKnight
pushed a commit
to HyphnKnight/tslint
that referenced
this pull request
Apr 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
Added an extra options to ordered-imports to enforce grouping by libraries, parent directories & the current directory.
Is there anything you'd like reviewers to focus on?
Should the grouping fix clear the sorting fixes?
CHANGELOG.md entry:
[new-rule-option]
"grouped-imports"forordered-importsrule