This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
no-submodule-imports: consider exact matches as whitelisted #3129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajafff
commented
Aug 14, 2017
| @@ -102,10 +99,6 @@ class NoSubmoduleImportsWalker extends Lint.AbstractWalker<string[]> { | |||
| } | |||
| } | |||
|
|
|||
| function isAbsoluteOrRelativePath(path: string): boolean { | |||
| return /^(..?(\/|$)|\/)/.test(path); | |||
There was a problem hiding this comment.
This one was actually wrong. it needed \. instead of just .
Anyways, we now use a typescript function which also check for C:\foo\bar as of typescript@2.5.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
Today I wanted to use the new
no-submodule-importsrule. I need to whitelist@angular/core/testingfor example, but doing that will check if the import starts with@angular/core/testing/(note the trailing slash).This PR also tests for exact matches, allowing me to whitelist
@angular/core/testinginstead of@angular/coreIs there anything you'd like reviewers to focus on?
CHANGELOG.md entry:
[enhancement]
no-submodule-importsallows whitelisting of submodules like@angular/core/testing