This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
New rule option: 'check-rest-spread' for 'whitespace' rule #3089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajafff
reviewed
Aug 2, 2017
src/rules/whitespaceRule.ts
Outdated
| @@ -27,6 +27,7 @@ const OPTION_DECL = "check-decl"; | |||
| const OPTION_OPERATOR = "check-operator"; | |||
| const OPTION_MODULE = "check-module"; | |||
| const OPTION_SEPARATOR = "check-separator"; | |||
| const OPTION_SPREAD = "check-spread"; | |||
There was a problem hiding this comment.
I'd prefer check-rest-spread which checks object and array spread as well as object and array rest and rest parameters
src/rules/whitespaceRule.ts
Outdated
| @@ -192,6 +196,13 @@ function walk(ctx: Lint.WalkContext<Options>) { | |||
| if (options.decl && initializer !== undefined) { | |||
| checkForTrailingWhitespace((type !== undefined ? type : name).getEnd()); | |||
| } | |||
| break; | |||
|
|
|||
| case ts.SyntaxKind.SpreadAssignment: | |||
There was a problem hiding this comment.
This also checks foo(...bar), which is correct if this option checks rest and spread.
It would also need to check BindingElement and Parameter where dotDotDotToken is not undefined and SpreadElement.
|
@ajafff thank you for the feedback! will get back to it soon |
adidahiya
approved these changes
Aug 10, 2017
adidahiya
changed the title
|
thanks @ksvitkovsky |
|
my pleasure 😊 |
|
Last build cause error, looks like prob in this option: /**
* Vue component 'preFetch' hook, that is used in SSR to do required
* things with given Vuex store before page rendering.
*
42: * @param store Vuex store, to perform actions on.
*
* @return Resolved promise with array of all users, that exist
* in the system.
*/Looks like it has conflict with option Default If remove |
HyphnKnight
pushed a commit
to HyphnKnight/tslint
that referenced
this pull request
Apr 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
CHANGELOG.md entry:
[new-rule-option]
whitespace: Addcheck-rest-spreadoption (#2122)