Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Fix 'space-before-function-paren' for anonymous/arrow generic functions #3085

Merged
merged 4 commits into from Sep 17, 2017
Merged

Fix 'space-before-function-paren' for anonymous/arrow generic functions #3085

merged 4 commits into from Sep 17, 2017

Conversation

ksvitkovsky
Copy link
Contributor

@ksvitkovsky ksvitkovsky commented Jul 31, 2017

PR checklist

Fix considers the following cases as exceptions and skips whitespace check:

  • arrow function with type parameters
  • anonymous functions with type parameters

@Jameskmonger
Copy link

Jameskmonger commented Aug 22, 2017

Will this fix the following case? I want it to be valid, but currently I get a lint issue.

const foo = <T>(a: T) => {};

@ajafff
Copy link
Contributor

ajafff commented Sep 12, 2017

@Jameskmonger The added tests tell that your code snippet would be valid after this PR lands

@ajafff ajafff merged commit 12d0cd2 into palantir:master Sep 17, 2017
@ajafff
Copy link
Contributor

ajafff commented Sep 17, 2017

Thanks @ksvitkovsky

@Jameskmonger
Copy link

@hisuwh This fixes the issue you were talking about.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants