This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
no-unused-variable: don't crash at destructuring #3058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid typescript crash when trying to get type of destructured variable declaration. Also avoid walking the AST multiple times when `--declaration` is not enabled. That should result in better performance and fewer false negatives. [bugfix] `no-unused-variable` fixed crash when using destructuring Fixes: #2876 Fixes: #3001
adidahiya
approved these changes
Aug 2, 2017
|
Hi, we would love to get this fix. Any idea when we can expect it to make its way into a release? |
|
@pelotom we'll try to release v5.6.0 this week. in the meantime you can grab the latest commit from master |
1 task
HyphnKnight
pushed a commit
to HyphnKnight/tslint
that referenced
this pull request
Apr 9, 2018
Avoid typescript crash when trying to get type of destructured variable declaration. Also avoid walking the AST multiple times when `--declaration` is not enabled. That should result in better performance and fewer false negatives. [bugfix] `no-unused-variable` fixed crash when using destructuring Fixes: palantir#2876 Fixes: palantir#3001
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
Avoid typescript crash when trying to get type of destructured variable declaration.
Also avoid walking the AST multiple times when
--declarationis not enabled. That should result in better performance and fewer false negatives.[bugfix]
no-unused-variablefixed crash when using destructuringFixes: #2876
Fixes: #3001
Is there anything you'd like reviewers to focus on?
CHANGELOG.md entry: