This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Handle unnamed default exports like anonymous functions (fixes #3040) #3053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajafff
approved these changes
Jul 18, 2017
|
Thanks @IllusionMH and @ajafff! |
HyphnKnight
pushed a commit
to HyphnKnight/tslint
that referenced
this pull request
Apr 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
space-before-function-parendoesn't detect anonymously exported function correctly #3040New feature,bugfix,or enhancementOverview of change:
This PR applies options for anonymous functions expression to default exports of function declarations without name.
Is there anything you'd like reviewers to focus on?
With this change there are no distinction between function declarations and function expression, therefore this two cases were combined.
There is no addition check for
defaultinmodifiersforFunctionDeclarationbecause other cases with omitted name are errors in TS/JS.Optionally behavior for unnamed functions as default export might be controlled with separate options, however this is likely an overkill.
CHANGELOG.md entry:
[bugfix]
space-before-function-parenHandle default exports of functions without names like anonymous functions (fixes #3040)