Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Recognize promise then call with rejection handler as valid floating promise handling #3048

Merged
merged 3 commits into from Jul 25, 2017

Conversation

vilicvane
Copy link
Contributor

@vilicvane vilicvane commented Jul 17, 2017

PR checklist

Overview of change:

createPromise()
  .then(() => next(), next); // No longer an error when rule `no-floating-promise` is enabled.

[bugfix] no-floating-promises: recognize rejection handler passed as second argument to promise.then()

@palantirtech
Copy link
Member

Thanks for your interest in palantir/tslint, @vilic! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

Copy link
Contributor

@ajafff ajafff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good, but this definitely needs a test.

@vilicvane
Copy link
Contributor Author

@ajafff Test added~ :)

@ajafff ajafff merged commit 3369ff8 into palantir:master Jul 25, 2017
@ajafff
Copy link
Contributor

ajafff commented Jul 25, 2017

Thanks @vilic

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants