Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

no-unsafe-any: allow truthyness and falsyness checks #3008

Merged
merged 2 commits into from Jul 7, 2017
Merged

no-unsafe-any: allow truthyness and falsyness checks #3008

merged 2 commits into from Jul 7, 2017

Conversation

ajafff
Copy link
Contributor

@ajafff ajafff commented Jul 6, 2017

PR checklist

Overview of change:

[bugfix] no-unsafe-any: allow truthyness and falsyness checks
Fixes: #2981

Is there anything you'd like reviewers to focus on?

There's some more work to do in this rule. It simply ignores some branches of the AST like destructuring and LHS of some binary expressions. Will fix that after this PR lands.

CHANGELOG.md entry:

[bugfix] `no-unsafe-any`: allow truthyness and falsyness checks
Fixes: #2981
@adidahiya adidahiya merged commit 37966e9 into palantir:master Jul 7, 2017
HyphnKnight pushed a commit to HyphnKnight/tslint that referenced this pull request Apr 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive(?) with no-unsafe-any
2 participants