completed-docs: Limit variable checking to file-level variables and use correct visibility

[reduckted]

PR checklist

• Addresses an existing issue: [completed-docs] exported variable parsed as internal variable #2335, completed-docs checks too many types of variables #2912
• New feature, bugfix, or enhancement
  • Includes tests
• Documentation update

Overview of change:

This PR fixes two issues:

1. When checking if a variable meets the required visibility, the modifiers on the variable were being used, but the variable doesn't have modifiers - the modifiers are on the variable statement which is two levels up. These changes step up two levels to get the correct modifiers.
2. When checking variables, all variables were being checked, including those inside for loops, catch statements, and local variables inside functions. This PR limits variable checking to variables that have a parent of a SourceFile - i.e. variables at the file-level.

As a side note, I've also fixed the .editorconfig file to have a rule for tslint.json files that enforces an indent size of 2 instead of the default 4, because all tslint.json files I could see used an indentation of 2.

CHANGELOG.md entry:

[bugfix] completed-docs: Uses correct visibility of variables.
[bugfix] completed-docs: Only checks variables at the file-level.

[ajafff]

node.parent as well as list.parent and statement.parent will never be undefined. You can simply assert that using for example node.parent!.kind

[ajafff]

what about (exported) variables inside a namespace (ts.SyntaxKind.ModuleBlock)?

[reduckted]

Good point 👍

[reduckted]

Just pushed up some changes suggested by @ajafff.

[ajafff]

statement.parent can not be undefined. This check ccould be simplified to

switch (statement.parent!.kind) {
    case ts.SyntaxKind.SourceFile:
    case ts.SyntaxKind.ModuleBlock:
        break;
    default:
        return;
}

[reduckted]

Doh! Sorry, missed that on your previous comment. Am I correct in assuming it's defined as parent?: Node because it can be undefined if the setParentNodes argument is false when you load the TypeScript source file. But since TSLint always passes true to that argument, the parent nodes will always be set (except on the root SourceFile node)?

[ajafff]

That's exactly how it works.

[ajafff]

Thanks @reduckted