This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Added NaN and (+/-)Infinity as numbers to no-inferrable-types #2885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the initializer text to logic in `typeIsInferrable`, and allows it to contain `Infinity`. Fixes #2777.
ajafff
reviewed
Jun 4, 2017
src/rules/noInferrableTypesRule.ts
Outdated
| @@ -77,7 +79,8 @@ class NoInferrableTypesWalker extends Lint.AbstractWalker<Options> { | |||
| const cb = (node: ts.Node): void => { | |||
| if (shouldCheck(node, this.options)) { | |||
| const { name, type, initializer } = node; | |||
| if (type !== undefined && initializer !== undefined && typeIsInferrable(type.kind, initializer.kind)) { | |||
| if (type !== undefined && initializer !== undefined | |||
| && typeIsInferrable(type.kind, initializer.kind, initializer.getText())) { | |||
There was a problem hiding this comment.
consider passing initializer as parameter instead of calling getText()
src/rules/noInferrableTypesRule.ts
Outdated
| switch (type) { | ||
| case ts.SyntaxKind.BooleanKeyword: | ||
| return initializer === ts.SyntaxKind.TrueKeyword || initializer === ts.SyntaxKind.FalseKeyword; | ||
| case ts.SyntaxKind.NumberKeyword: | ||
| return initializer === ts.SyntaxKind.NumericLiteral; | ||
| return initializer === ts.SyntaxKind.NumericLiteral || initializerText.indexOf(INFINITY_TEXT) !== -1; |
There was a problem hiding this comment.
A little helper to avoid getText(), handle negative numbers, Infinity, -Infinity, and NaN
function isNumeric(node: ts.Expression) {
while (isPrefixUnaryExpression(node) &&
(node.operator === ts.SyntaxKind.PlusToken || node.operator === ts.SyntaxKind.MinusToken)) {
node = node.operand;
}
return node.kind === ts.SyntaxKind.NumericLiteral ||
isIdentifier(node) && (node.text === "NaN" || node.text === "Infinity");
}There was a problem hiding this comment.
Sure. Side note: do we want to include "NaN" for this?
There was a problem hiding this comment.
For the sake of consistency we should include NaN. Otherwise Infinity shouldn't be included either.
There was a problem hiding this comment.
👍
Also just noticed I missed an 'f' in the commit for your username. Whoops :)
ajafff
approved these changes
Jun 5, 2017
|
@JoshuaKGoldberg Don't forget to update the PR description and changelog entry to state that the rule now also handles negative number and |
JoshuaKGoldberg
changed the title
|
Thanks :) |
adidahiya
approved these changes
Jul 7, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
no-inferrable-typesrule doesn't detectInfinityas an inferrable numeric literal #2777Overview of change:
Adds the initializer text to logic in
typeIsInferrable, and allows it to containInfinity.Fixes #2777.
CHANGELOG.md entry:
[enhancement] Added NaN and (+/-)Infinity as numbers to
no-inferrable-types