This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
strict-boolean-expressions: Allow 'any', and 'true' and 'false' literal types #2758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-hanson
commented
May 14, 2017
| @@ -95,12 +95,10 @@ boolType ? strType : undefined; | |||
| !enumType; | |||
| ~~~~~~~~ [This type is not allowed in the operand for the '!' operator because it is an enum. Only booleans are allowed.] | |||
| !!classType; | |||
| ~~~~~~~~~~ [This type is not allowed in the operand for the '!' operator because it is always falsy. Only booleans are allowed.] | |||
There was a problem hiding this comment.
!classType is of type false, thus the removed error.
ajafff
approved these changes
May 15, 2017
adidahiya
approved these changes
May 24, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
Starts allowing the types 'any', 'true', or 'false' if they appear exactly.
Will still not allow an always-truthy/falsy union (e.g.
true | Date).CHANGELOG.md entry:
[enhancement]
strict-boolean-expression: Allowany, andtrueandfalseliteral types