This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
CLI: handle directories passed with -p #2756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Search for tsconfig.json in specified directory. Exit with error if there is none. Ref: #2692 [enhancement] cli: `-p` option handles directories
andy-hanson
reviewed
May 13, 2017
src/runner.ts
Outdated
| if (!fs.existsSync(this.options.project)) { | ||
| let project: string; | ||
| try { | ||
| project = findTsconfig(this.options.project); |
There was a problem hiding this comment.
I think this function should handle error handling itself (and return string | undefined) instead of throwing an error whose value is ignored.
| @@ -175,9 +178,6 @@ export class Runner { | |||
| // if not type checking, we don't need to pass in a program object | |||
| program = undefined; | |||
| } | |||
| } else if (this.options.typeCheck) { | |||
There was a problem hiding this comment.
Why did you move this code?
There was a problem hiding this comment.
all static option validation is done in tslint-cli.ts
runner.ts should only be responsible to catch errors that occur at runtime
nchen63
approved these changes
May 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
Search for tsconfig.json in specified directory. Exit with error if there is none.
Ref: #2692
[enhancement] cli:
-poption handles directoriesIs there anything you'd like reviewers to focus on?
CHANGELOG.md entry: