This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
deprecation: Rewrite and enhance #2748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrite to walker function. Use TypeScript's JsDoc parser [enhancement] `deprecation`: error message includes deprecation text if available
andy-hanson
reviewed
May 13, 2017
| this.addFailureAtNode(node, `${node.text} is deprecated.`); | ||
| function getDeprecation(node: ts.Identifier, tc: ts.TypeChecker): string | undefined { | ||
| let symbol = tc.getSymbolAtLocation(node); | ||
| if (symbol !== undefined && Lint.isSymbolFlagSet(symbol, ts.SymbolFlags.Alias)) { |
There was a problem hiding this comment.
We could use a skipAliasSymbol helper in tsutils.
andy-hanson
reviewed
May 13, 2017
| if (declarations === undefined) { | ||
| super.visitIdentifier(node); | ||
| return; | ||
| function isDeclaration(identifier: ts.Identifier): boolean { |
There was a problem hiding this comment.
TypeScript has ts.isDeclarationName, but it's internal. You could make an issue on the TypeScript issue asking it to be made non-internal since it seems pretty useful.
There was a problem hiding this comment.
Or I could: microsoft/TypeScript#15811
There was a problem hiding this comment.
The implementation used here is slightly different. For example typescript's implementation includes ShorthandPropertyAssignment which actually uses the variable and should therefore be checked by this rule. Same with NamespaceImport, ...
adidahiya
approved these changes
May 24, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
Rewrite to walker function.
Use TypeScript's JsDoc parser
[enhancement]
deprecation: error message includes deprecation text if availableIs there anything you'd like reviewers to focus on?
CHANGELOG.md entry: