This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
space-before-function-paren: Rewrite #2700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajafff
reviewed
May 7, 2017
| } | ||
| case ts.SyntaxKind.MethodDeclaration: | ||
| case ts.SyntaxKind.MethodSignature: | ||
| return options.method; |
There was a problem hiding this comment.
could you add SetAccessor and GetAccessor while you are already editing this rule?
| const option = getOption(node, options); | ||
| if (option !== undefined) { | ||
| const openParen = Lint.childOfKind(node, ts.SyntaxKind.OpenParenToken)!; | ||
| const hasSpace = sourceFile.text[openParen.pos] !== "("; |
There was a problem hiding this comment.
this line should be changed to handle comments:
const hasSpace = ts.isWhiteSpaceLike(sourceFile.text.charCodeAt(openParen.end - 2));
andy-hanson
force-pushed
the
space-before-function-paren
branch
from
7e28339
to
5b3f4e8
Compare
ajafff
approved these changes
May 7, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
Just a refactor.
The previous implementation had special handling for FunctionDeclaration with an empty name; since this is a compiler error anyway, removed the special handling and its associated tests.
CHANGELOG.md entry:
[enhancement]
space-before-function-paren: Handleget/setaccessor