This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Enable 'prefer-switch' rule and raise default 'min-cases' #2669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajafff
reviewed
May 3, 2017
src/rules/noInferrableTypesRule.ts
Outdated
| @@ -104,8 +104,10 @@ class NoInferrableTypesWalker extends Lint.AbstractWalker<IOptions> { | |||
|
|
|||
| switch (node.type.kind) { | |||
| case ts.SyntaxKind.BooleanKeyword: | |||
| if (node.initializer.kind === ts.SyntaxKind.TrueKeyword || node.initializer.kind === ts.SyntaxKind.FalseKeyword) { | |||
| failure = "boolean"; | |||
| switch (node.initializer.kind) { | |||
There was a problem hiding this comment.
maybe we could set the threshold to 3
IMO these short switch statements bloat the code unnecessary
| } | ||
| return true; |
There was a problem hiding this comment.
you could leave this return and remove the default clauses above
There was a problem hiding this comment.
I like the default so it's easy to tell that there's no fallthrough.
andy-hanson
changed the title
ajafff
approved these changes
May 4, 2017
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
Just enables the rule and fixes new lint failures.
EDIT: Also raises the default
min-cases.CHANGELOG.md entry:
[enhancement]
prefer-switch: Change defaultmin-casesto 3.