Really fix type parameter of applyWithFunction

[ajafff]

PR checklist

• Addresses an existing issue: Fix type parameter of applyWithFunction #2396
• New feature, bugfix, or enhancement
  • Includes tests
• Documentation update

Overview of change:

Followup on #2396:
Using U extends T allows excess properties.
Using {} & T does stricter type checking (no more excess properties and enables linting the parameter with no-unsafe-any) and also fixes the inference problem with arrow functions: #2396 (comment)

Is there anything you'd like reviewers to focus on?

This change may technically break dependent libraries if they explicitly specified the type parameters. In reality possibly noone ever did that. On the other hand this change may reveal bugs during type checking.

CHANGELOG.md entry:

[api] AbstractRule#applyWithFunction has better type checking for its type parameter

[nchen63]

{} & T doesn't seem to be encouraged microsoft/TypeScript#14829 (comment)

[ajafff]

Seems like this is now the preferred way to exclude a parameter from type inference. It's even suggested by TypeScript devs microsoft/TypeScript#17491 (comment)

[ajafff]

CI failed to compile. Looks like this solution will not work for all cases.
I'll investigate further and try to find a working solution.

[ajafff]

I managed to work around the type error. Cross posting microsoft/TypeScript#14829 (comment) for reference

T & {} only works when not using strictNullChecks.
I encountered a problem when T is undefined, because undefined is not assignable to undefined & {}.

I found that mapped types also defer inference, so i tried type InferLast<T> = Readonly<T>;
That does not work for types with index signatures like arrays.

My final solution is a mapped type intersected with the type itself:

export type NoInfer<T> = T & {[K in keyof T]: T[K]};