This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
New rule prefer-object-spread #2624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[new-rule] `prefer-object-spread` Fixes: #2618
|
Looks great once you get the tests passing! |
|
In order to get the tests passing, I needed to change the sorting of the replacements. That could be considered a breaking change, but I rather think this is a bug fix. The tests of all other rules still pass. The sorting of the replacements should be refactored afterwards. It should take into account if a replacement adds, removes or replaces text and sort accordingly. |
nchen63
reviewed
May 11, 2017
| @@ -150,7 +150,7 @@ export class Replacement { | |||
|
|
|||
| public static applyAll(content: string, replacements: Replacement[]) { | |||
| // sort in reverse so that diffs are properly applied | |||
| replacements.sort((a, b) => b.end - a.end); | |||
| replacements.sort((a, b) => b.end - a.end || b.start - a.start); | |||
There was a problem hiding this comment.
we shouldn't even be applying overlapping fixes
nchen63
approved these changes
May 11, 2017
adidahiya
approved these changes
May 17, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
[new-rule]
prefer-object-spreadFixes: #2618
/cc @danvk
Is there anything you'd like reviewers to focus on?
I'm not sure if
functionalityis the right type in the metadata.CHANGELOG.md entry: