Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

object-literal-sort-keys: rewrite, handle spread and shorthand #2592

Merged
merged 5 commits into from May 6, 2017
Merged

object-literal-sort-keys: rewrite, handle spread and shorthand #2592

merged 5 commits into from May 6, 2017

Conversation

ajafff
Copy link
Contributor

@ajafff ajafff commented Apr 16, 2017

PR checklist

Overview of change:

[new-rule-option] object-literal-sort-keys adds ignore-case
Fixes: #1924
[enhancement] object-literal-sort-keys: check shorthand properties
Fixes: #2205
[bugfix] object-literal-sort-keys: handle object spread correctly
Fixes: #2554

Is there anything you'd like reviewers to focus on?

Numbers are still excluded because it doesn't make sense to sort them alphabetically.
Methods and accessors are also still ignored.

Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs conflict resolution

[new-rule-option] `object-literal-sort-keys` adds `ignore-case`
Fixes: #1924
[enhancement] `object-literal-sort-keys`: check shorthand properties
Fixes: #2205
[bugfix] `object-literal-sort-keys`: handle object spread correctly
Fixes: #2554
@ajafff
Copy link
Contributor Author

ajafff commented Apr 17, 2017

@adidahiya rebased and resolved conflicts.
Now I have a problem with no-unsafe-any and labels. That seems to be resolved with the latest version of the rule, but the one in tslint@latest doesn't like my code

@ajafff
Copy link
Contributor Author

ajafff commented May 4, 2017

@adidahiya @nchen63 CI is green now that tslint@5.2 is released. This should be good to go

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants