This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Rewrite 'no-shadowed-variable' #2339
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-hanson
force-pushed
the
no-shadowed-variable
branch
from
6eac039
to
32ab09a
Compare
ajafff
reviewed
Mar 14, 2017
| @@ -174,7 +174,7 @@ function resolveConfigurationPath(filePath: string, relativeTo?: string) { | |||
| } catch (err) { | |||
| try { | |||
| return require.resolve(filePath); | |||
| } catch (err) { | |||
| } catch (anotherErr) { | |||
There was a problem hiding this comment.
we should probably add some options to ignore catched exceptions and maybe variable names matching a regex. That way you don't need a new name for nested try...catch blocks or errorback style callbacks
| public createScope() { | ||
| return new Set(); | ||
| } | ||
| class Walker extends Lint.AbstractWalker<void> { |
There was a problem hiding this comment.
Don't get me wrong, but to me this implementation seems to be overly complex for this use case.
Do you mind if I try to come up with a simpler approach?
There was a problem hiding this comment.
Sure. Be sure to test for type parameters, namespaces, etc.
This was referenced Apr 8, 2017
|
@andy-hanson thanks for the reminder and sorry for the delay. I'll have time to look into this early next week. Should be ready no later than on tuesday. |
4 tasks
|
closing in favor of #2598 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
Complete rewrite of
no-shadowed-variable.Now checks for shadowing of types too (e.g.
interface Foo { m<Foo>(): Foo }).Also now no ignores variables named 'this'.