Preserve newlines and tabs when autofixing quote marks

[moritzg91]

PR checklist

• Addresses an existing issue: Autofixing incorrectly handles strings with \n #2202
• New feature, bugfix, or enhancement
• Includes tests
• Documentation update

What changes did you make?

Simple change in quotemarkRule::visitStringLiteral. Search the escaped text for \n and \t and replace with escaped versions. Also added a string containing tab/newline to the test cases for the quotemark rule.

Is there anything you'd like reviewers to focus on?

First PR to this project, so I'm sorry if I missed something obvious

[palantirtech]

Thanks for your interest in palantir/tslint, @moritzg91! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

[nchen63]

try getting node.getText(), which will return a string with escaped characters, so you don't have to do the second replace. Otherwise you'd need to add a more replacement characters like "\" and "\r".

[moritzg91]

makes sense, updated to use getText.

[nchen63]

looks good, thanks for the contribution!

[jmlopez-rod]

I'm using tslint 4.5.1 but the problem with the escaped characters still seems to be present.

I'm having this

 { code: "var {\nx,y\n} = y", options: ["never"] },

turned into

  { code: 'var {
x,y
} = y', options: ["never"] },

[nchen63]

can't reproduce on 4.5.1. if it's still an issue, please open a ticket

[jmlopez-rod]

I should have checked using the command line, @nchen63 you are correct. The issue I'm seeing is with my IDE. I'm using

IntelliJ IDEA 2017.1 EAP
Build #IU-171.3224.1, built on February 14, 2017
IntelliJ IDEA EAP User
Expiration date: March 16, 2017
JRE: 1.8.0_112-release-b702 x86_64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Mac OS X 10.12

It has a feature to fix the issues (uses the output provided by tslint) but it seems that this is the culprit and not tslint.

I'll update and see if they fixed it, otherwise I'll report the issue.

EDIT: It's fixed.