Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Rewrite and bugfix no-switch-case-fallthrough #2218

Merged
merged 1 commit into from Feb 24, 2017
Merged

Rewrite and bugfix no-switch-case-fallthrough #2218

merged 1 commit into from Feb 24, 2017

Conversation

ajafff
Copy link
Contributor

@ajafff ajafff commented Feb 17, 2017

PR checklist

What changes did you make?

[bugfix] handle break, throw, continue and return nested in block, if-else and switch
[bugfix] allow empty case clauses before default clause
[enhancement] allow single line comment // falls through

Is there anything you'd like reviewers to focus on?

Depends on #2217

[bugfix] handle break, throw, continue and return nested in block, if-else and switch
[bugfix] allow empty case clauses before default clause
[enhancement] allow single line comment `// falls through`
@nchen63 nchen63 merged commit 894d0e0 into palantir:master Feb 24, 2017
@nchen63
Copy link
Contributor

nchen63 commented Feb 24, 2017

@ajafff thanks!

@ajafff ajafff deleted the switch-fallthrough branch February 24, 2017 20:36
@ajafff
Copy link
Contributor Author

ajafff commented Feb 24, 2017

Github didn't automatically closed the other open issues mentioned above: #950, #1033, #1538

@glen-84
Copy link
Contributor

glen-84 commented Jul 2, 2017

The // falls through comment check should probably be case-insensitive and allow additional text.

  • // falls through
  • // Falls through
  • // Falls through.
  • // Falls through -- for reasons.

@ajafff
Copy link
Contributor Author

ajafff commented Jul 2, 2017

@glen-84 makes sense. I opened #2983 to address this.

@ajafff ajafff mentioned this pull request Sep 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

switch-case-fall-through check failed on blocked case clauses
3 participants