This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Add ignore-properties to no-inferrable-types #2178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I approve of the changelog style entries 👍 👍 |
|
@ajafff thanks! |
buu700
reviewed
Feb 8, 2017
| @@ -28,20 +34,26 @@ export class Rule extends Lint.Rules.AbstractRule { | |||
| description: "Disallows explicit type declarations for variables or parameters initialized to a number, string, or boolean.", | |||
| rationale: "Explicit types where they can be easily infered by the compiler make code more verbose.", | |||
| optionsDescription: Lint.Utils.dedent` | |||
| One argument may be optionally provided: | |||
| Two argument may be optionally provided: | |||
There was a problem hiding this comment.
btw, looks like you forgot to make "argument" plural.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
What changes did you make?
[new-fixer] automatically remove inferrable type annotations
[new-rule-option] added
ignore-propertiesoption tono-inferrable-typesMinor Refactoring to use the new
AbstractWalkerIs there anything you'd like reviewers to focus on?
Not sure about the option name.
Parametersis abbreviated toparams. Maybe I should do the same forproperties->props?