This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Add a rule to ban specified types from being used in type annotations or type assertions. #2175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… or type assertions.
|
Thanks for your interest in palantir/tslint, @calebegg! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
|
I am covered by the Google corporate CLA. |
nchen63
suggested changes
Feb 7, 2017
src/rules/banTypesRule.ts
Outdated
| public static metadata: Lint.IRuleMetadata = { | ||
| ruleName: "ban-types", | ||
| description: Lint.Utils.dedent` | ||
| Bans specific global types from being used. Does not ban the |
src/rules/banTypesRule.ts
Outdated
| }, | ||
| }, | ||
| optionsDescription: Lint.Utils.dedent` | ||
| A list of \`["type", "optional explanation here"]\`, which bans |
|
Makes sense. Done. |
nchen63
approved these changes
Feb 7, 2017
|
@calebegg thanks! |
|
It looks like I can't merge this because the CLA bot doesn't understand corporate CLAs. |
|
Ah, no problem. I guess I didn't realize my membership wasn't public until now. I'll look into that on my end. |
|
Figured it out, so it should work next time. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
What changes did you make?
I added a new rule,
ban-types, that allows a list of specified global types to be banned from use, similar to the existingbanrule for functions.