This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Add no-import-side-effect rule
#2155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your interest in palantir/tslint, @mgechev! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
mgechev
force-pushed
the
no-import-side-effect
branch
from
10adc78
to
7198965
Compare
nchen63
suggested changes
Jan 31, 2017
| @@ -0,0 +1,21 @@ | |||
| { | |||
There was a problem hiding this comment.
file path should be ignore-module not ignore-pattern
| @@ -0,0 +1,78 @@ | |||
| /** | |||
| * @license | |||
| * Copyright 2015 Palantir Technologies, Inc. | |||
mgechev
force-pushed
the
no-import-side-effect
branch
from
7198965
to
f23e688
Compare
|
@nchen63 thanks for the review! I addressed your comments. |
nchen63
approved these changes
Jan 31, 2017
|
@mgechev thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2116
PR checklist
What changes did you make?
Introduced a rule which warns when used imports with side-effects. For more details here #2116.
Is there anything you'd like reviewers to focus on?
Have I added the required documentation.