This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
member-ordering: Add 'alphabetize' option #2101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchen63
reviewed
Jan 23, 2017
| } | ||
|
|
||
| const curName = nameString(member.name); | ||
| if (prevName !== undefined && curName < prevName) { |
There was a problem hiding this comment.
I think < takes case into account, but I don't think it should
There was a problem hiding this comment.
For example, in ordered-imports, we use < and >, but it calls out case-insensitive, lowercase-first and lowercase-last. I think we could just default to case insensitive and call .toLowerCase() before comparison
|
@andy-hanson please rebase |
andy-hanson
force-pushed
the
alphabetize
branch
from
9367644
to
f1728d2
Compare
|
@andy-hanson thanks! |
|
How to use the option? It's not apparent from the documentation. |
|
@ackvf Pass the 'alphabetize' option to the options object of the member-ordering rule. Example: "member-ordering": [
true,
{
"order": [
"static-field",
"instance-field",
"static-method",
"instance-method"
],
"alphabetize": true
}
], |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
What changes did you make?
Added the 'alphabetize' option to member-ordering, which enforces alphabetical ordering within each category.
Is there anything you'd like reviewers to focus on?
This uses
<for string comparison. I think.localeComparewould be troublesome if people in different locales want linting to succeed on all of their machines.