This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Add no-unbound-method rule
#2089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchen63
suggested changes
Jan 21, 2017
| }; | ||
| /* tslint:enable:object-literal-sort-keys */ | ||
|
|
||
| public static FAILURE_STRING = "'this' may be unbound when a method is used as a property without being invoked."; |
There was a problem hiding this comment.
How about `Avoid referencing unbound class methods which may cause unintentional scoping of 'this'"
There was a problem hiding this comment.
Removed "class" from that since it may be on an interface.
nchen63
approved these changes
Jan 21, 2017
|
nice, thanks! |
|
Nothing like closing a 2 year old feature request 😃 Can we add tests for JSX usage? As per #259 (comment) and palantir/tslint-react#63 |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
What changes did you make?
Added the
no-unbound-methodrule, which forbids the use ofx.foowherefoois a method on a class or interface, but allowsy => x.foo(y).