This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Add prefer-method-signature rule
#2028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How does this interact with |
|
I guess the fix wouldn't fully fix it in that case, because the method would then have to be manually re-ordered. |
nchen63
suggested changes
Jan 13, 2017
| /* tslint:disable:object-literal-sort-keys */ | ||
| public static metadata: Lint.IRuleMetadata = { | ||
| ruleName: "prefer-method-signature", | ||
| description: "Prefer `foo(): void` over `foo: () => void`.", |
There was a problem hiding this comment.
append "in interface and types"
| public static metadata: Lint.IRuleMetadata = { | ||
| ruleName: "prefer-method-signature", | ||
| description: "Prefer `foo(): void` over `foo: () => void`.", | ||
| optionsDescription: "Not configurable.", |
nchen63
approved these changes
Jan 14, 2017
|
@andy-hanson thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
What changes did you make?
Added the
prefer-method-signaturerule, which recommends to usefoo(): voidoverfoo: () => void.It looks like these will be semantically equivalent in TS2.2. (And were in 2.0.) microsoft/TypeScript#13148 (comment)