Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Fix prefer-const for TypeScript <2.1 #1989

Merged
merged 1 commit into from
Jan 5, 2017
Merged

Fix prefer-const for TypeScript <2.1 #1989

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/rules/preferConstRule.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,15 @@ class PreferConstWalker extends Lint.BlockScopeAwareRuleWalker<{}, ScopeInfo> {
}

private static collectInVariableDeclarationList(node: ts.VariableDeclarationList, scopeInfo: ScopeInfo) {
if (isCombinedNodeFlagSet(node, ts.NodeFlags.Let) && !isCombinedModifierFlagSet(node, ts.ModifierFlags.Export)) {
let allowConst: boolean;
if ((ts as any).getCombinedModifierFlags === undefined) {
// for back-compat, TypeScript < 2.1
allowConst = isCombinedNodeFlagSet(node, ts.NodeFlags.Let)
&& !Lint.hasModifier(node.parent!.modifiers, ts.SyntaxKind.ExportKeyword);
} else {
allowConst = isCombinedNodeFlagSet(node, ts.NodeFlags.Let) && !isCombinedModifierFlagSet(node, ts.ModifierFlags.Export);
}
if (allowConst) {
for (const decl of node.declarations) {
PreferConstWalker.addDeclarationName(decl.name, node, scopeInfo);
}
Expand Down