This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Fix only-arrow-functions #1961
Merged
Fix only-arrow-functions #1961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-hanson
reviewed
Jan 1, 2017
|
|
||
| constructor(sourceFile: ts.SourceFile, options: Lint.IOptions) { | ||
| super(sourceFile, options); | ||
| this.allowDeclarations = options.ruleArguments.indexOf(OPTION_ALLOW_DECLARATIONS) !== -1; |
There was a problem hiding this comment.
Why not use this.hasOption here?
There was a problem hiding this comment.
options is already in scope, so why not use it.
I don't have a strong opinion on this one
There was a problem hiding this comment.
Let's go with this.hasOption for consistency
andy-hanson
reviewed
Jan 2, 2017
| } | ||
| } | ||
|
|
||
| private getFunctionKeyword(node: ts.FunctionLikeDeclaration): ts.Node { |
There was a problem hiding this comment.
thanks, I changed it to use the new helper function
nchen63
suggested changes
Jan 4, 2017
|
|
||
| constructor(sourceFile: ts.SourceFile, options: Lint.IOptions) { | ||
| super(sourceFile, options); | ||
| this.allowDeclarations = options.ruleArguments.indexOf(OPTION_ALLOW_DECLARATIONS) !== -1; |
There was a problem hiding this comment.
Let's go with this.hasOption for consistency
nchen63
approved these changes
Jan 4, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
What changes did you make?
allow-named-functionsallow-declarations, but function declarations are also namedasyncorexported functionsIs there anything you'd like reviewers to focus on?
The ci failure will go away when #1960 get's merged and this branch is rebased... and it's gone