Add fix for object-literal-key-quotes

[andy-hanson]

PR checklist

• Addresses an existing issue: Autofix object-literal-key-quotes #1911
• New feature, bugfix, or enhancement
  • Includes tests
• Documentation update
• Enable CircleCI for your fork (https://circleci.com/add-projects)

What changes did you make?

Added fixes for object-literal-key-quotes (except in consistent mode, where a fix would be ambiguous).

Is there anything you'd like reviewers to focus on?

This always uses double quotes. Might it be possible to peer into the setting for quotemark and choose quotes accordingly?

[mohsen1]

I'm interested to know how rules can know about other rule's options

[nchen63]

I don't think we want to encourage rules looking at the options of a different rule. I'm fine with the fix using double quotes since most people use double quotes, and the quotemark fixer is likely to come after object-literal-key-quotes and fix the quote type anyways.

[nchen63]

@andy-hanson thanks!

[mohsen1]

I think allowing quote preference as an option would be nice. Might work on a pr today

[mohsen1]

Actually if quote rule fix come after this fix it will fix it.

I suggest making sure the recommended config has the right order of these two rules

[ajafff]

the quotemark fixer is likely to come after object-literal-key-quotes and fix the quote type anyways.

@nchen63 how is that possible? They operate on the same AST so the order doesn't matter, as the quotemark rule wont see the quotes added by object-literal-key-quotes until the next run.

With --fix linting is run twice - second run without fixing -, if there were fixes. The quotes would only be reported as lint errors but are not fixed.

[nchen63]

@ajafff The AST is reloaded each time fixes are made. See linter.ts, line 121.

If it didn't reload, then 2 different fixes would incorrectly be applied since fixes are position based and fix 1 could later offsets to be different than expected.