This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Add typeof-compare rule #1927
Merged
Add typeof-compare rule #1927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohsen1
force-pushed
the
add-typeof-compare-rule
branch
from
bdb352c
to
854c226
Compare
|
How should I update documentation for this? |
|
you can run the doc generator by running |
|
@natgabb done |
nchen63
reviewed
Jan 1, 2017
| ~~~~~~~~~~~~~~~~~~~~~~~~~~ [typeof must be compared to correct value] | ||
|
|
||
| const string = "string"; | ||
| typeof bar === string |
There was a problem hiding this comment.
needs more positive tests. Currently only tests against a string variable. Needs to test against directly against a string, against a template string, and a template string with a replacement variable. Also exercise different types of valid types
|
Hmmm failures don't make sense to me |
nchen63
reviewed
Jan 1, 2017
| } | ||
|
|
||
| private static isLegalStringLiteral(node: ts.Node) { | ||
| return ComparisonWalker.LEGAL_TYPEOF_RESULTS.indexOf(node.getText()) > -1; |
There was a problem hiding this comment.
it's failing here because node.getText() includes the quotes. For example, "string" instead of what you want: string. If you use node.text, it will exclude the quotes
|
@mohsen1 thanks for the contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
What changes did you make?
Added
typeof-comparerule. It makes sure result oftypeofexpressions are always compared to legal strings. I originally asked TypeScript to make comparing result oftypeofto illegal strings a compiler error but per spectypeofcan return anything!Is there anything you'd like reviewers to focus on?
This is my first rule. I'm almost certain I'm missing stuff in this PR.