This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Fix restrict-plus-operands for ternary ops #1925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adidahiya
changed the title
restruct-plus-operands for ternary ops
adidahiya
suggested changes
Dec 25, 2016
| @@ -40,6 +41,8 @@ export class Rule extends Lint.Rules.TypedRule { | |||
| } | |||
| } | |||
|
|
|||
| type AddTypes = "string" | "number" | "invalid"; | |||
There was a problem hiding this comment.
I don't think we need a new type for this; I would prefer the union inlined in two places. This change makes the code more confusing
| @@ -60,12 +63,34 @@ class RestrictPlusOperandsWalker extends Lint.ProgramAwareRuleWalker { | |||
| } | |||
| } | |||
|
|
|||
| function getAddableType(node: ts.Expression, tc: ts.TypeChecker): "string" | "number" | "invalid" { | |||
| function getAddableType(node: ts.Expression, tc: ts.TypeChecker): AddTypes { | |||
There was a problem hiding this comment.
I don't think this extra function in the call stack is necessary -- would prefer to inline usage of getBaseTypeOfLiteralType above, like so:
const tc = this.getTypeChecker();
const leftType = getBaseTypeOfLiteralType(ts.getTypeAtLocation(node.left));
...| } | ||
| return "invalid"; | ||
| } | ||
|
|
||
| function allSame(array: string[]) { |
There was a problem hiding this comment.
I think this would be nicer with Array#reduce
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1922