Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Crash on Object's rest operator which was added in TypeScript 2.1.4 #1916

Closed
rhysd opened this issue Dec 23, 2016 · 0 comments
Closed

Crash on Object's rest operator which was added in TypeScript 2.1.4 #1916

rhysd opened this issue Dec 23, 2016 · 0 comments
Milestone

Comments

@rhysd
Copy link
Contributor

rhysd commented Dec 23, 2016

Bug Report

  • TSLint version: 4.2.0
  • TypeScript version: 2.1.4
  • Running TSLint via: CLI

TypeScript code being linted

const o = {};
const o2 = { ...o };

with tslint.json configuration:

{
  "rules": {
    "object-literal-key-quotes": [
      true,
      "as-needed"
    ]
  }
}

Actual behavior

Crash with below log:

/Users/me/MyProject/node_modules/tslint/lib/runner.js:117
            throw error;
            ^

TypeError: Cannot read property 'kind' of undefined
    at ObjectLiteralKeyQuotesWalker.noneMayHaveQuotes (/Users/me/MyProject/node_modules/tslint/lib/rules/objectLiteralKeyQuotesRule.js:107:23)
    at ObjectLiteralKeyQuotesWalker.visitObjectLiteralExpression (/Users/me/MyProject/node_modules/tslint/lib/rules/objectLiteralKeyQuotesRule.js:73:22)
    at ObjectLiteralKeyQuotesWalker.SyntaxWalker.visitNode (/Users/me/MyProject/node_modules/tslint/lib/language/walker/syntaxWalker.js:430:22)
    at /Users/me/MyProject/node_modules/tslint/lib/language/walker/syntaxWalker.js:517:63
    at visitNode (/Users/me/MyProject/node_modules/typescript/lib/typescript.js:13895:20)
    at Object.forEachChild (/Users/me/MyProject/node_modules/typescript/lib/typescript.js:13957:21)
    at ObjectLiteralKeyQuotesWalker.SyntaxWalker.walkChildren (/Users/me/MyProject/node_modules/tslint/lib/language/walker/syntaxWalker.js:517:12)
    at ObjectLiteralKeyQuotesWalker.SyntaxWalker.visitVariableDeclaration (/Users/me/MyProject/node_modules/tslint/lib/language/walker/syntaxWalker.js:251:14)
    at ObjectLiteralKeyQuotesWalker.SyntaxWalker.visitNode (/Users/me/MyProject/node_modules/tslint/lib/language/walker/syntaxWalker.js:496:22)
     /Users/me/MyProject/node_modules/tslint/lib/language/walker/syntaxWalker.js:517:63

Expected behavior

tslint does not crash and check the rule properly

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants