Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

fix (almost) all tslint errors #121

Closed
wants to merge 1 commit into from
Closed

fix (almost) all tslint errors #121

wants to merge 1 commit into from

Conversation

keforbes
Copy link
Collaborator

I installed the tslint plugin for my IDE and found there were a bunch of tslint errors in Oni. I decided to go through and fix them all. Well, almost. All of the UI components have a require("./xxx.less") line which tslint doesn't like but I don't know how to change a less file to an import statement so I left those alone.

If you don't actually care about tslint errors or you haven't really configured the tslint.json to your liking then you can delete this Pull Request. I just figured it was an easy fix.

@bryphe
Copy link
Member

bryphe commented Dec 23, 2016

Thanks for making these @keforbes , appreciate it! Hopefully once #56 is here these will be discoverable inside ONI as well. The change looks good overall, but it seems like there is a compile error in the typescript plugin - I'll approve it and merge once that's fixed.

@bryphe
Copy link
Member

bryphe commented Dec 25, 2016

Looks like the object-key-literal-quotes rule is causing problems in tslint, which was just fixed recently:
palantir/tslint#1916

I'll ignore the rule for now until we can pull the fix in

@bryphe bryphe mentioned this pull request Dec 31, 2016
bryphe pushed a commit that referenced this pull request Dec 31, 2016
* Add install/uninstall global scripts

* fix (almost) all tslint errors

* Update package.json to pick up.tsx files before, which were missed

* Fix require issues with tslint

* Fix last require issue
@bryphe
Copy link
Member

bryphe commented Dec 31, 2016

Finished this up in PR #133 - thanks!

@bryphe bryphe closed this Dec 31, 2016
@keforbes keforbes deleted the tslint-fixes branch January 5, 2017 22:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants